Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added readme cover #283

Merged

Conversation

Mukulbaid63
Copy link
Contributor

@Mukulbaid63 Mukulbaid63 commented Nov 6, 2020

Your checklist for this pull request

⚠️ Please review the guidelines for contributing to this repository.

Parent issue: #6

Type of change

Select all that applies:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have used consistent code conventions and clear function/method/variable names.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md which contains description, requirements and use case.
  • I have added relevent screenshots/images if necessary in a seperate folder.
  • I have added my work in respective language folder.
  • My changes generate no new warnings.

❤️ Thank you!

@Mukulbaid63
Copy link
Contributor Author

@tejan-singh have a look

@kuldip11
Copy link
Contributor

kuldip11 commented Nov 6, 2020

it's really looks cool @Mukulbaid63

@yashaswibiyahut
Copy link
Contributor

Good work @Mukulbaid63
Thanks for contribution 👍

@yashaswibiyahut yashaswibiyahut merged commit 3f9fb6a into sanscript-tech:main Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants