Skip to content

Password Strength Checker in C++ #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Password Strength Checker in C++ #361

wants to merge 3 commits into from

Conversation

japneetkaurbhatia
Copy link
Contributor

Your checklist for this pull request

⚠️ Please review the guidelines for contributing to this repository.

Parent issue: #299

Type of change

Select all that applies:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have used consistent code conventions and clear function/method/variable names.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md which contains description, requirements and use case.
  • I have added relevent screenshots/images if necessary in a seperate folder.
  • I have added my work in respective language folder.
  • My changes generate no new warnings.

❤️ Thank you!


If Password is 6-chacter long with uppercase or Lowercase and special character then it is Moderate

otherwise its Weak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add sample use case or example

@@ -0,0 +1,36 @@
#include <iostream>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all extra spaces


using namespace std;

void CheckPassword(string& input)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add proper comments

If Password is 8-character long and have uppercase, lowercase , digit and special character then it is Strong

If Password is 6-chacter long with uppercase or Lowercase and special character then it is Moderate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add time and space complexity

@yashaswibiyahut
Copy link
Contributor

Please squash the commits

@tejan-singh
Copy link
Contributor

@japneetbhatia do not send a pull request from the main branch, Create another branch and send pr from that branch. Read contribution guidelines for more details.

@japneetkaurbhatia
Copy link
Contributor Author

Ok @tejan-singh @yashaswibiyahut I'll correct this by today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants