Conversation
Shrink the state struct from 80 to 32 bytes via two changes: - Move matches []pattern out of state into a map[stateID][]pattern on iNFA. Only match states (rare) need this; the hot path (hasMatch) uses the matchBitset and is unchanged. Saves 24 bytes/state (~85MB). - Move dense transitions out of state into a flat []stateID table on iNFA, indexed by a per-state int32 offset (-1 for sparse). Eliminates the transitions struct entirely. Only ~66K dense states (depth < 3) use this; the other ~3.7M sparse states no longer carry a nil 24-byte slice header. Saves another 24 bytes/state (~85MB). The contiguous table also improves cache locality (parse-bench ratio 1.27x -> 1.23x). Peak RSS on a real scan: ~710MB -> ~460MB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shrink the state struct from 80 to 32 bytes via two changes:
Move matches []pattern out of state into a map[stateID][]pattern on iNFA. Only match states (rare) need this; the hot path (hasMatch) uses the matchBitset and is unchanged. Saves 24 bytes/state (~85MB).
Move dense transitions out of state into a flat []stateID table on iNFA, indexed by a per-state int32 offset (-1 for sparse). Eliminates the transitions struct entirely. Only ~66K dense states (depth < 3) use this; the other ~3.7M sparse states no longer carry a nil 24-byte slice header. Saves another 24 bytes/state (~85MB). The contiguous table also improves cache locality (parse-bench ratio 1.27x -> 1.23x).
Peak RSS on a real scan: ~710MB -> ~460MB.