[neutron] add rbac related parts for ovn #7852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toanju
requested review from
notandy,
fwiesel,
sebageek,
sven-rosenzweig,
rhalina,
swagner-de,
mutax,
BenjaminLudwigSAP,
m-kratochvil and
occamshatchet
as code owners
fwiesel
reviewed
Feb 7, 2025
fwiesel
reviewed
Feb 7, 2025
Comment on lines
+35
to
+44
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: ovnkube-db | ||
| rules: | ||
| - apiGroups: [""] | ||
| resources: | ||
| - nodes | ||
| - namespaces | ||
| verbs: [ "get", "list", "watch" ] |
There was a problem hiding this comment.
I suspect we can patch that out: https://github.com/ovn-kubernetes/ovn-kubernetes/blob/d3b10e87f7fffa38fdf4ad52f98bc8ba998df6c2/dist/images/ovnkube.sh#L736-L743,
and then do not need access to the node api either.
There was a problem hiding this comment.
for now I'd like to keep it and do as less patching as needed since we should rewrite that with a proper operator anyway
This adds the following kinds used by ovn: * ClusterRole * ClusterRoleBinding * Role * RoleBinding * ServiceAccount
toanju
force-pushed
the
toanju/neutron/ovn-rbac
branch
from
6f8e449 to
f8ab8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following kinds used by ovn: