Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SC-5 docs following GA #2592

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Updating SC-5 docs following GA #2592

merged 5 commits into from
Jan 16, 2024

Conversation

waggledans
Copy link
Contributor

@waggledans waggledans commented Jan 16, 2024

Description

Motivation and Context

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

Copy link

Deploy preview ready for 2592!
https://docs.dev.saucelabs.net
built from 7462029

Copy link

Deploy preview ready for 2592!
https://docs.dev.saucelabs.net
built from f66033c

label: 'Sauce Connect Proxy 4',
collapsed: true,
items: [
'secure-connections/sauce-connect',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By leaving these as SC4 docs, anything external is going to keep pointing here. If we switch to sauce-connect-4 for the old ones and move sauce-connect-5 to sauce-connect, they'll get the new ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we discussed and decided to not break sc-4 links for now and leave them as is. We should probably update the links as well later but this MR changes the sidebar only.

@waggledans waggledans merged commit fe5dc42 into main Jan 16, 2024
7 checks passed
@waggledans waggledans deleted the dans-sc5-ga branch January 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants