Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dosc/sc5: rework installation docs #2647

Merged
merged 1 commit into from
Feb 21, 2024
Merged

dosc/sc5: rework installation docs #2647

merged 1 commit into from
Feb 21, 2024

Conversation

Choraden
Copy link
Contributor

@Choraden Choraden commented Feb 16, 2024 •
edited
Loading

Description

This patch makes install section for each of the platforms.

Linux, macOS, and Windows instructions were rewritten. Docker and Kubernetes instructions were only moved, the content needs to be reworked.

Fixes SC-4583

Motivation and Context

This gives a nice structure for installation docs. They are all in one place. Each one references one platform.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

@Choraden Choraden force-pushed the hg/sc5_install_docs branch from 8d2e9c3 to 91fb805 Compare February 16, 2024 16:15
@Choraden Choraden requested a review from a team as a code owner February 16, 2024 16:15
@Choraden Choraden force-pushed the hg/sc5_install_docs branch 2 times, most recently from 08452db to db4b82c Compare February 16, 2024 16:25
@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from 101f3ac

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from a403d74

@waggledans
Copy link
Contributor

have to have a high-level doc available at https://docs.saucelabs.com/secure-connections/sauce-connect-5/installation/

@Choraden
Copy link
Contributor Author

have to have a high-level doc available at https://docs.saucelabs.com/secure-connections/sauce-connect-5/installation/

Agree. Do you know if this Screenshot 2024-02-16 at 17 53 36 Installation section can have its content?

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from d30520a

@Choraden Choraden force-pushed the hg/sc5_install_docs branch from 7fa0f50 to 4497317 Compare February 16, 2024 17:31
@Choraden
Copy link
Contributor Author

Do you know if this Installation section can have its content?

Found that.

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from ae6896b

@Choraden Choraden force-pushed the hg/sc5_install_docs branch from 4497317 to 2971b22 Compare February 19, 2024 07:18
@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from 1ada14d

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from 2ff4c80

@Choraden Choraden force-pushed the hg/sc5_install_docs branch 2 times, most recently from 9577e1a to a7dac2d Compare February 21, 2024 10:06
@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from 3ea179c

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from cfff20a

@Choraden
dosc/sc5: rework installation docs
72ef211 
This patch makes install section for each of the platforms. This gives a nice structure.

Linux, macOS, and Windows instructions were rewritten.
Docker and Kubernetes instructions were only moved, the content needs to be reworked.

Fixes SC-4583
@Choraden Choraden force-pushed the hg/sc5_install_docs branch from a7dac2d to 72ef211 Compare February 21, 2024 10:19
@github-actions GitHub Actions
Copy link

Deploy preview ready for 2647!
https://docs.dev.saucelabs.net
built from 4c3b3b5

@Choraden Choraden merged commit e79ac18 into main Feb 21, 2024
7 checks passed
@Choraden Choraden deleted the hg/sc5_install_docs branch February 21, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waggledans waggledans waggledans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Choraden @waggledans