Retry openurl on failure #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
reviewed
Oct 22, 2025
src/index.js
Outdated
| await idbCompanion.boot(device.udid, timeout * 1000); | ||
| } catch (recoveryError) { | ||
| debug(`Recovery error: ${recoveryError}`); | ||
| throw new Error("Simulator recovery failed. Aborting operation."); |
Author
There was a problem hiding this comment.
As above, I have updated the throw to include the error message.
perf2711
reviewed
Nov 6, 2025
Co-authored-by: Sebastian Alex <[email protected]>
Co-authored-by: Sebastian Alex <[email protected]>
Util already included
perf2711
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding retry logic to openurl command that will shutdown the simulator, re-launch the device, and attempt the openurl command again.