If anyone interested, fixed some minor bugs and applied a bit of my style #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 5, 2024 21:02
add missing confirmation and error messages; ask for confirmation for deleting articles; redirect to profile/article when creating/editing; put delete button on article page instead of edit page; add icon to unfavorite button and change its color; transform number of likes/followers to int instead of float; add profile link on navigation; include number of followers on button to follow on profile; fix username being required to be email on register; fix something with register... I don't know how it was working before; fix spacing, positioning and some other fluffy stuff; laravel pint fixing styling and add bootstrap 5 (on top of 4 + custom styles omg);
marcelaodev
changed the title
added 7 commits
November 6, 2024 21:34
…u only if profile is self
fix checkboxes not working properly when you edit an article without any tag; fix tag feed not ordered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well I don't mean this to ever be merged. (while the previous I do)
But I'd like to share a bit of what I've done here... fixed some minor bugs like not showing validation messages but there's also some of what I consider to be more elegant.
(I guess I should just have disabled auto formatting, changes are hard to look that way)
It's the first time I paid some time to develop some stuff on the TALL stack and I gotta say: it's AWESOME!
With about 900 lines of code we have a web page with a similar UX as of this same project written instead in React with about 6k lines.
I don't usually have free choice to pick my stack, but this is now certainly my GO TO web stack!