refactor: prepare standalone usage of buttons #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeripeierSBB
force-pushed
the
button-refactoring-6
branch
from
7be39b7 to
42a4966
Compare
github-actions
bot
added
diff-available
and removed
preview-available
diff-available
labels
jeripeierSBB
force-pushed
the
button-refactoring-6
branch
from
c8156d1 to
daec027
Compare
jeripeierSBB
added
the
pr: ux review required
github-actions
bot
added
the
pr: peer review required
jeripeierSBB
commented
Jan 6, 2025
mcilurzo
added
ux approved
|
LGTM! |
jeripeierSBB
added
pr: ux review approved
# Conflicts: # src/elements/core/a11y/focus.ts
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
added
pr: peer review required
sbb-design-systems-bot bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
We want to provide mixins for the sbb-button to allow place it on a native `<button>` element. To achieve this goal, this PR refactors the styles of the button, which is a prerequisite for #3075
kyubisation
pushed a commit
that referenced
this pull request
Feb 6, 2025
🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.0...v2.2.0) (2025-02-06) ### Features * **sbb-autocomplete:** opens automatically on new options ([#3365](#3365)) ([8ca33ef](8ca33ef)) ### Bug Fixes * avoid moving content when blocking scrolling ([#3369](#3369)) ([f7b84ad](f7b84ad)) * display non bubbling events in storybook actions ([#3355](#3355)) ([fdf9899](fdf9899)), closes [#3354](#3354) * provide `accessibility-current` property for link elements ([#3384](#3384)) ([5a3168e](5a3168e)) * **sbb-datepicker-toggle:** allow defining slot attribute ([#3376](#3376)) ([87c97ba](87c97ba)), closes [#3375](#3375) * **sbb-datepicker-toggle:** reset popover style ([#3386](#3386)) ([789f0a5](789f0a5)) * **sbb-radio-button-group:** prevent didChange emit from nested group ([#3371](#3371)) ([3fca755](3fca755)) ### Documentation * fix typo in GETTING_STARTED.md ([#3372](#3372)) ([d8b48ce](d8b48ce)) * **sbb-popover:** enable focusing link in storybook ([#3359](#3359)) ([6c23eeb](6c23eeb)) ### Code Refactoring * prepare standalone usage of buttons ([#3326](#3326)) ([154370b](154370b)) * **sbb-title, sbb-dialog-title:** remove obsolete h1-h6 tags ([#3363](#3363)) ([a64ea72](a64ea72)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide mixins (classes?) for the sbb-button to allow place it on a native
<button>element. To achieve this goal, this PR refactors the styles of the button, which is a prerequisite for #3075Open topics: