-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(API): sbpp_checker library name #1034
Open
Rushaway
wants to merge
5
commits into
sbpp:php81
Choose a base branch
from
Rushaway:api
base: php81
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this ready for review, or still draft? |
Draft. I need to edit it later today. |
@rumblefrog Ready to be merged with a squash commit. |
Hello @rumblefrog any input? |
I will remind myself to take a look when I can, but if it looks good to you, you can stamp it. |
rumblefrog
reviewed
Feb 6, 2025
maxime1907
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix library name conflict between
sbpp_checker
andsbpp_main
(both were usingsourcebans++
)sbpp_main
keepssourcebans++
sbpp_checker
now usessourcebanspp_checker
This allows proper verification of specific libraries via
LibraryExists
and avoids any confusion between the two plugins.Description
The main issue is a library name conflict where both sbpp_checker and sbpp_main were using the same name "sourcebans++" when registering their library via
RegPluginLibrary
. This was causing problems when checking for library existence withLibraryExists
.Motivation and Context
LibraryExists
withsourcebans++
for using sbpp checker natives, wich was always incorrect to due the sameRegPluginLibrary
as sbpp_main.How Has This Been Tested?
Tested with a test plugin implementing all new forwards:
Screenshots (if appropriate):
Types of changes
Checklist: