Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up action #33

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Clean up action #33

merged 1 commit into from
Dec 23, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 22, 2024

  • Add outputs
  • Consistently use environment variables for ${{ steps }}
  • Skip needless pushd/popd
  • Name the SBT_CACHE_KEY_VERSION field to make it avoid magic numbers
  • Provide outputs for the various publicly observable details of the action

action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
* Consistently use environment variables for ${{ steps }}
* Skip needless `pushd`/`popd`
* Name the `SBT_CACHE_KEY_VERSION` field to make it avoid magic numbers
* Provide outputs for the various publicly observable details of the
  action
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 845a5b9 into sbt:main Dec 23, 2024
5 checks passed
@jsoref jsoref deleted the action-cleanup branch December 23, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants