Initialize last_loaded_map

[yvesbar]

initialize "last_loaded_map" if None to get rid of "'NoneType' object has no attribute 'get'" warning.
Fix #324

Summary by CodeRabbit

• Bug Fixes
  • Improved sensor data processing to consistently present default mapping information when actual data is missing. This enhancement ensures a more reliable and stable display by supplying a preset value when the expected sensor data isn’t available.

[coderabbitai]

Walkthrough

The changes modify the async_update_sensor_data method in the MQTTVacuumCoordinator class. The logic now ensures that if the last_loaded_map key is missing or evaluates as falsy in sensor_data, it is initialized to a default value of {"name": "Default"}. Previously, the code only checked for an empty dictionary and attempted an incorrect default assignment. This update prevents errors such as the 'NoneType' object has no attribute 'get' warning by guaranteeing that last_loaded_map always holds a valid dictionary.

Changes

File	Change Summary
custom_components/…/coordinator.py	Modified async_update_sensor_data: now checks for falsy last_loaded_map and sets a default value of {"name": "Default"} instead of checking for an empty dict.

Sequence Diagram(s)

sequenceDiagram
    participant S as Sensor Data Provider
    participant C as MQTTVacuumCoordinator
    participant L as Logger

    S->>C: Deliver sensor_data
    C->>C: Retrieve last_loaded_map from sensor_data
    alt last_loaded_map is missing or falsy
        C->>C: Set last_loaded_map = {"name": "Default"}
    end
    C->>L: Log processed sensor data (or proceed with update)

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ensure sensor data processing handles missing last_loaded_map to avoid 'NoneType' errors (#324)	✅

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

custom_components/mqtt_vacuum_camera/coordinator.py (1)

153-154: Consider removing redundant check 🤔

Since we already provide a default value when getting last_loaded_map from sensor_data on line 149, this additional check might be redundant. The .get() method with a default value ensures we never have a falsy last_loaded_map.

-                if not last_loaded_map:
-                    last_loaded_map = {"name": "Default"}

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e425a8 and 6b14161.

📒 Files selected for processing (1)

• custom_components/mqtt_vacuum_camera/coordinator.py (1 hunks)

🔇 Additional comments (1)

custom_components/mqtt_vacuum_camera/coordinator.py (1)

149-149: Sweet fix! Default value prevents NoneType errors 🎯

Adding a default value when getting last_loaded_map from sensor_data is a solid defensive programming move. It ensures we always have a valid dictionary with a "name" key.

[sca075]

thanks a lot @yvesbar ;)