Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pathToInput for any inputKind #19

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Jan 22, 2022

Downstream tests (notably
scala-js/scala-js#4623) can profit from the
ability to abstract over an input kind.

Downstream tests (notably
scala-js/scala-js#4623) can profit from the
ability to abstract over an input kind.
@gzm0 gzm0 requested a review from sjrd January 22, 2022 12:14
@sjrd sjrd merged commit 3fcca96 into scala-js:main Jan 22, 2022
@sjrd
Copy link
Member

sjrd commented Jan 22, 2022

Tell me when you need a release with your changes ;)

@gzm0
Copy link
Contributor Author

gzm0 commented Jan 22, 2022

Yep :) I'm looking at #20 ATM as well. It's probably also a 1-line fix or so. I just need to set-up the testing :)

@gzm0 gzm0 deleted the expose-path-to-input branch January 22, 2022 13:01
@gzm0
Copy link
Contributor Author

gzm0 commented Jan 30, 2022

Given how #20 looks like right now, I think we should release to unblock scala-js/scala-js#4623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants