Skip to content

Updated pages to be “Scala 3 Only” #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

alvinj
Copy link
Contributor

@alvinj alvinj commented Feb 1, 2023

I’m not sure if I did this right, but I updated these three pages to be “Scala 3 Only,” per the Action Plan we put together back in December.

@alvinj
Copy link
Contributor Author

alvinj commented Feb 1, 2023

Note that this is the 2nd item in that Action Plan (a Google Doc).

In that code the parameter name `ord` isn’t actually required; it can be passed on as an inferred argument to `max`, so you just state that `maximum` uses the type `Ord[A]` without giving it a name:

{% tabs context-bounds-no-param-name %}

{% tab 'Scala 3 Only' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so anonymous context parameter truly is a scala 3 only thing, so if you add Scala 2 tab to context-bounds-max-named-param, then this paragraph and snippet can go in the scala 3 tab there (i.e. drop the context-bounds-no-param-name tabs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve removed this example from the ca-context-bounds.md file because I don’t think it should be part of that file. Instead, I think we should move it to the file ca-given-using-clauses.md.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe it’s better to have it in this file. If you think it should be here, let me know and I’ll update it.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alvin for this work!

- remove tag “Scala 3 only”
- add a link to the page that explains context parameters and inferred terms
- remove paragraph that shows anonymous context parameters
- fix link to the FAQ
- also cross-write the FAQ entry
@alvinj
Copy link
Contributor Author

alvinj commented Feb 4, 2023

I’m sorry I’m late on this, and I’m not a Git expert, so I hope I did this right: I just added some text to the top of the Multiversal Equality page, and I wanted to see if that’s what you had in mind? If not, just let me know. (And if I did something wrong in Git, just let me know that, too.)

I was also going to make a few changes later in this page to make it read a little more smoothly, but I thought I’d handle that separately.

Also, if you like this approach, I can do the same thing on the “Given Imports” page (to be consistent), if you’d like.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thank you Alvin!

@julienrf julienrf requested a review from bishabosha February 6, 2023 09:00
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great, thank you for your work!

@bishabosha
Copy link
Member

I updated #2481 with the completed pages

@alvinj alvinj deleted the scala-3-only-pages branch February 6, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants