Add code tabs to Syntactic Changes #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Mar 8, 2023
|
I also have a question, is it better to make Scala2/Scala3 tabs or just keep the code with the error and a Scala3 tab only. Then another Scala3 code afterwards for the solution? |
Dedelweiss
changed the title
julienrf
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Hey @Dedelweiss, thank you very much for helping with the docs!
I started reviewing your PR and I have left several comments already, it seems there was some confusion about how to use the code tabs. Hopefully with my comments below this is clearer?
julienrf
approved these changes
Mar 10, 2023
|
Thanks for your feedback and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my PR to add code tabs to the Syntactic changes
Ref #2481