Skip to content

Add code tabs to the Scala 3 Dropped Features #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

Dedelweiss
Copy link
Contributor

@Dedelweiss Dedelweiss commented Mar 8, 2023

Here is my PR proposition to add code tabs to the Dropped Features page

Before:

Screenshot 2023-03-08 at 12 27 00

Screenshot 2023-03-08 at 12 26 47

After:

Screenshot 2023-03-08 at 12 26 30

Screenshot 2023-03-08 at 12 26 40

Ref #2481

- Change some titles
- Change spelling of errors
- Put out some sentence from tabs
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Dedelweiss, this is much clearer this way! I’ve found one place where we can use “Scala 2 and 3” instead of “Scala 3 Only”.

@Dedelweiss Dedelweiss requested a review from julienrf March 11, 2023 18:06
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@julienrf julienrf merged commit 8e8e357 into scala:main Mar 13, 2023
@Dedelweiss Dedelweiss deleted the tabs_dropped_features branch March 13, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants