Add code tabs to contextual abstractions page #2724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedelweiss
changed the title
Dedelweiss
changed the title
julienrf
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Hey @Dedelweiss, I took some time to review the PR. I noticed an issue with a leftover ~~~, and a misplaced sentence, could you please fix them?
_overviews/scala3-migration/incompat-contextual-abstractions.md
Outdated
Show resolved
Hide resolved
_overviews/scala3-migration/incompat-contextual-abstractions.md
Outdated
Show resolved
Hide resolved
- Change tabs title - Re-add Highlight diff and Highlight text
Dedelweiss
force-pushed
the
contextual_abstractions
branch
from
85376d8 to
3bf5ba1
Compare
Corrected, thank you for the feedback |
julienrf
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my PR proposition to add code tabs to the Dropped Features page
Before:
After :
Ref #2481