Add code tabs to type checker page #2726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedelweiss
changed the title
julienrf
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Hey @Dedelweiss, thank you for all these PRs.
I started reviewing but I see that you not only added code tabs, but you also changed other things. I think in this page (and in the other pages about the migration from Scala 2 to Scala 3), we should keep the {% highlight diff %} sections because they show clearly the steps to make Scala 2 code compile with Scala 3. Could you please restore these sections?
julienrf
reviewed
Mar 10, 2023
- Change the spelling of the sentence line 35 - Change the tab line 122 to Scala 2 and 3 - Put the sentence line 129 outside the tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my PR to add code tabs to the type checker page
Ref: #2481