Skip to content

update os-lib versions in example #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

KevinBoyette
Copy link
Contributor

This is nothing that's really that important to merge as the tooling tells you exactly what to do and the documentation is really good. When compiling the examples from the documentation with scala-cli, we get warnings about the version being outdated.

[hint] "os-lib is outdated, update to 0.11.3"
[hint]      os-lib 0.9.1 -> com.lihaoyi::os-lib:0.11.3
[hint] //> using dep com.lihaoyi::os-lib:0.9.1
[hint]               ^^^^^^^^^^^^^^^^^^^^^^^^^

This bumps the versions to the latest versions that I could find and that would compile on my machine.

@adpi2
Copy link
Member

adpi2 commented Feb 12, 2025

Thanks @KevinBoyette

I would very much appreciate if you could also update the versions in the other install-*.md files, so that we don't have inconsistent versions of the Toolkit, and underlying libraries, in different pages.

The latest toolkit library versions can be found here: https://index.scala-lang.org/scala/toolkit

@KevinBoyette
Copy link
Contributor Author

I'd be more than happy to update those files as well. I pushed up some changes and have checked that scala-cli can pull those down for both scala 3.4.2 and 2.13.16

//> using dep com.lihaoyi::cask::0.10.2
//> using dep com.lihaoyi::os-lib:0.11.3
//> using dep com.lihaoyi::upickle:4.1.0
//> using dep com.softwaremill.sttp.client4::core:4.0.0-M26
//> using dep org.scalameta::munit:1.1.0
//> using scala "2.13.16" 

object Main extends App {
  println("Hello World")
}

and

//> using dep com.lihaoyi::cask::0.10.2
//> using dep com.lihaoyi::os-lib:0.11.3
//> using dep com.lihaoyi::upickle:4.1.0
//> using dep com.softwaremill.sttp.client4::core:4.0.0-M26
//> using dep org.scalameta::munit:1.1.0
//> using scala "3.4.2" 

object Main extends App {
  println("Hello World")
}

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated sttp to the latest 4.0.0-RC1. Apart from that it's all good.

Thanks a lot for your help. It's really appreciated!

@KevinBoyette
Copy link
Contributor Author

Any time! Thank you for all the work on docs, your help, and time reviewing my changes

@adpi2 adpi2 merged commit ad7324c into scala:main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants