Skip to content

Fix an invalid link #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

artemkorsakov
Copy link
Contributor

There is an invalid link on the following page:
https://docs.scala-lang.org/sips/futures-promises.html

image

Fixed!

@SethTisue @adpi2 please, review this PR.

@SethTisue
Copy link
Member

what's weird is that I had already fixed this myself, but it appears that some bot undid the fix: 7ec2ca6

before merging this, I'd like to understand what happened there so we can prevent it from recurring. @kyouko-taiga @hamzaremmal do you know anything about this "Scala Improvement Bot" ?

@hamzaremmal
Copy link
Member

what's weird is that I had already fixed this myself, but it appears that some bot undid the fix: 7ec2ca6

It needs to be fixed in the SIP repository, not here. The SIP bot will synchronise the content of this repo with the content from the SIP repo. Therefore, any change you do here, will be overridden by the content in improvement-proposals

@kyouko-taiga
Copy link
Contributor

I opened scala/improvement-proposals#106

@hamzaremmal hamzaremmal closed this Mar 3, 2025
@artemkorsakov artemkorsakov deleted the Fix-invalid-links branch March 3, 2025 11:59
@hamzaremmal
Copy link
Member

hamzaremmal commented Mar 3, 2025

I've just triggered the sync from the scala/improvement-proposals repo: 64d88df. Should be good now.

@SethTisue
Copy link
Member

thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants