Ensure archive fetch script uses HTTPS download #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent an MitM possible by downloading the releases in plain text (using HTTP). Per scala/scala-lang#627 this script appears to make artifacts available on scala-lang.org and so any form of attack here could be problematic.
ashawley
approved these changes
Apr 4, 2017
|
thanks! |
|
2.11.x backport: 01285f0 also merged forward onto 2.13.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent an MitM possible by downloading the releases
in plain text (using HTTP). Per scala/scala-lang#627 this script
appears to make artifacts available on scala-lang.org and so any
form of attack here could be problematic.