Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building an existing tag against a new Scala version #24

Merged
merged 2 commits into from
Apr 25, 2017

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Apr 20, 2017

For tags of the form v1.2.3-suffix#2.13.0-M1, the build script
releases version 1.2.3-suffix using Scala version 2.13.0-M1.

This allows building an existing tag against a new Scala version.

@lrytz
Copy link
Member Author

lrytz commented Apr 20, 2017

Same patch as in scala/scala-swing#59, already used successfully.

@lrytz
Copy link
Member Author

lrytz commented Apr 21, 2017

Needs more refinements, closing for now

@lrytz lrytz closed this Apr 21, 2017
@lrytz lrytz reopened this Apr 25, 2017
@lrytz lrytz force-pushed the tag-with-scala-version branch 2 times, most recently from 9a36184 to e6b26df Compare April 25, 2017 09:28
@lrytz
Copy link
Member Author

lrytz commented Apr 25, 2017

This should be ready now, I'll merge it after lunch :)

@lrytz lrytz mentioned this pull request Apr 25, 2017
@lrytz
Copy link
Member Author

lrytz commented Apr 25, 2017

Ah the travis build failed. It's because the sbt plugin enables -Xlint, and this build has fatal warnings. It didn't fail before because the compiler option that the plugin intends to enable were not actually enabled. It used scalacOptions in compile instead of scalacOptions in (Compile, compile). This is fixed in 1.0.7. I'll push a fix.

@lrytz lrytz force-pushed the tag-with-scala-version branch from e6b26df to ff4a1b5 Compare April 25, 2017 09:40
For tags of the form `v1.2.3-suffix#2.13.0-M1#8`, the build script
releases version `1.2.3-suffix` using Scala version `2.13.0-M1` on
Java version 8.

This allows building an existing tag against a new Scala version.
@lrytz lrytz force-pushed the tag-with-scala-version branch from ff4a1b5 to 51eff60 Compare April 25, 2017 10:43
@lrytz
Copy link
Member Author

lrytz commented Apr 25, 2017

Merging, will test it out with some -TEST tags.

@lrytz lrytz merged commit 6680445 into scala:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant