-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building an existing tag against a new Scala version #109
Conversation
Same patch as in scala/scala-swing#59, already used successfully. We should then merge 1.0.x into master to get this in the other branch. |
I realize I need to do something about |
Yeah, that complicates everything, see #86. |
d2bea19
to
ff206dc
Compare
@gourlaysama I included your changes from #111, this should be good to go now. |
8a921b9
to
78ccb57
Compare
@lrytz that last commit won't work until scala-js for 2.13.0-M1 is released, but the rest LGTM. |
Thanks! I heard scala-js should happen soon, so we can wait if that's fine for you. |
For tags of the form `v1.2.3-suffix#2.13.0-M1`, the build script releases version `1.2.3-suffix` using Scala version `2.13.0-M1`. This allows building an existing tag against a new Scala version.
78ccb57
to
26d971a
Compare
🎉! |
Nice! We'll have to get this into the
Should all of these be merged forward? Also, to be more in line with scala/scala and other module repos, should we rename |
ping @gourlaysama - no rush, just to know if you saw comment above? |
I just pushed v1.0.6, but publishing partially failed (2.11 and 2.12 were published, but not 2.13.0-M1), see https://travis-ci.org/scala/scala-parser-combinators/builds/227935497 |
Ah, it tried to publish the root project... |
And everything is green. The staging repositories are:
@lrytz Could you also close the two older staging repos (from the first try): orgscala-lang-1417 and orgscala-lang-1418? |
@lrytz I have just tested those jars and everything seems ok. All that's left is promoting the two repos and waiting for them to get to maven central :) |
@gourlaysama promoted. Thanks a lot! |
For tags of the form
v1.2.3-suffix#2.13.0-M1
, the build scriptreleases version
1.2.3-suffix
using Scala version2.13.0-M1
.This allows building an existing tag against a new Scala version.