StdLexical now emits one ErrorToken for unclosed comments. #403
Conversation
|
(let us know if you need help understanding & addressing the CI failures) |
|
@SethTisue Thank you. I have fixed the ListBuffer issue (which was not about Scala.js but Scala 2.12 and below). The binary compatibility issue, I have tried to fix changing a new method from protected to private which is also correct because overriding it or calling it from a derived class does not make much sense. If it does not work, I will ask for help. :) |
|
@SethTisue Please let me know if there is anything that prevents this and my other issue from being merged – e.g., if you would like something done in a different way, or simply don't like the changes. |
|
@Philippus Also, rebased this branch on top of issue-397 as it depends on the test file added in issue-397. |
| import scala.util.parsing.input.Reader | ||
|
|
||
| import scala.collection.mutable.ListBuffer | ||
| import java.awt.RenderingHints.Key |
There was a problem hiding this comment.
I think this import isn't used.
There was a problem hiding this comment.
@Philippus you are absolutely correct. Sorry about that. The import actually made it's way into this file in the previous pull request (PR402). This PR only makes a few changes to this file.
@Test
def parseUnclosedComments: Unit = {
object Lexer extends StdLexical
import Lexer._
assertEquals(
List(Identifier("id"), ErrorToken("unclosed comment")),
lex(Lexer, "id /*")
)
assertEquals(
List(Identifier("id"), ErrorToken("unclosed comment")),
lex(Lexer, "id /* ")
)
}However, because branch issue-399 currently is on top of issue-397 you see the diff of both issues in this PR. I will remove the unused import and rebase this PR on top of 2.x.
The remaining input is consumed so the ErrorToken is the last token emitted by the scanner.
Fixes issue #399