Remove test duplication #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ashawley
reviewed
Feb 9, 2017
| val e: scala.xml.MetaData = Null //Node.NoAttributes | ||
| val sc: scala.xml.NamespaceBinding = TopScope | ||
| } | ||
|
|
||
| class XMLTest { | ||
| class XMLTestJVM { | ||
| import XMLTest.{ e, sc } |
There was a problem hiding this comment.
import XMLTestJVM... although why there's a companion object, I have no idea.
There was a problem hiding this comment.
Good catch! Force pushed the change.
…required Moving jv tests to shared introduced name conflicts on the duplicated calsses, the rename solves that
OlivierBlanvillain
force-pushed
the
deduplicate-tests
branch
from
60f1c7f to
2eafecb
Compare
|
I don't think there's any reason not to merge this. The duplication is indeed fixed. I'm sure there will be more re-work in the wake of these Scalajs changes. |
SethTisue
approved these changes
Feb 9, 2017
|
I'm going to go ahead and hit "merge" on this one since it may affect in-flight PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the test duplication introduced in #109.
As a defaults, new test should be added in
shared/src/test. Parts that are JVM specific should go injvm/src/testinstead.