XML attributes parsed in reverse order #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashawley
commented
Oct 23, 2017
| foldLeft(Null: MetaData) { (x, xs) => | ||
| xs.copy(x) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the manner that the recursive data structure is reversed.
ashawley
commented
Oct 23, 2017
| @@ -134,7 +134,7 @@ abstract class FactoryAdapter extends DefaultHandler with factory.XMLLoader[Node | |||
| if (scopeStack.isEmpty) TopScope | |||
| else scopeStack.top | |||
|
|
|||
| for (i <- 0 until attributes.getLength()) { | |||
| for (i <- (0 until attributes.getLength).reverse) { | |||
There was a problem hiding this comment.
This is where it is added to the SAX parser infrastructure
ashawley
commented
Oct 23, 2017
| @@ -340,7 +340,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { | |||
| if (!aMap.wellformed(scope)) | |||
| reportSyntaxError("double attribute") | |||
|
|
|||
| (aMap, scope) | |||
| (aMap.reverse, scope) | |||
There was a problem hiding this comment.
This is where it is added to the constructing parser infrastructure
ashawley
force-pushed
the
fix-attribute-order
branch
2 times, most recently
from
2bec171 to
11f9d09
Compare
ashawley
force-pushed
the
fix-attribute-order
branch
from
11f9d09 to
4e956fa
Compare
ashawley
force-pushed
the
fix-attribute-order
branch
from
4e956fa to
1e3573e
Compare
ashawley
force-pushed
the
fix-attribute-order
branch
from
1e3573e to
f0691d3
Compare
ashawley
force-pushed
the
fix-attribute-order
branch
from
f0691d3 to
eaf1532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #65 and scala/bug#6341