Fix failure for empty attribute match #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashawley
force-pushed
the
fix-fail-empty-attrib
branch
2 times, most recently
from
e3811d4 to
4d959d4
Compare
|
The only concern is if someone has clunky code that happened to be doing an attribute search on a collection of nodes with the empty string. This change would suddenly raise an exception in that scenario, rather than silently returning the empty node list. |
ashawley
force-pushed
the
fix-fail-empty-attrib
branch
2 times, most recently
from
994f1c4 to
6fce346
Compare
ashawley
force-pushed
the
fix-fail-empty-attrib
branch
from
6fce346 to
0c7069f
Compare
Running the following invalid attribute search, properly throws an
IllegalArgumentException.
scala> <x/> \ "@"
java.lang.IllegalArgumentException: @
scala> <x/> \@ ""
java.lang.IllegalArgumentException: @
There's no such thing as an empty attribute.
However, when the improper matching value is used against more than
just one element, no error is thrown, just an empty NodeSeq is
returned:
scala> <x><y/><z/></x>.child \ "@"
res1: scala.xml.NodeSeq = NodeSeq()
It should be a failure.
Similarly, the attribute search method, is similarly affected.
scala> <x><y/><z/></x>.child \@ ""
res1: scala.xml.NodeSeq = NodeSeq()
This was identified while writing ScalaCheck property tests.
ashawley
force-pushed
the
fix-fail-empty-attrib
branch
from
0c7069f to
9a0db27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249.