Improve handling of language flags by Vulpix #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 6, 2020
som-snytt
force-pushed
the
issue/test-language
branch
2 times, most recently
from
f18117c to
1ae00b7
Compare
som-snytt
force-pushed
the
issue/test-language
branch
from
1ae00b7 to
96c3356
Compare
som-snytt
force-pushed
the
issue/test-language
branch
from
96c3356 to
8096394
Compare
anatoliykmetyuk
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in processing existing
-language:foo,bar,baz(which were always dropped).Per the code comment, just add
-language:foowhen asked to, now that #9719 is fixed.This means if a test is configured twice to add a language flag, it will be added twice.
Per the bug fix, if removed, both instances of the flag are removed.