batch files support installation path containing spaces #13577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dist/bin/scalac.bat
Outdated
| set "__TOOLCHAIN=%__TOOLCHAIN%%_JLINE_READER%%_PSEP%" | ||
| set "__TOOLCHAIN=%__TOOLCHAIN%%_JLINE_TERMINAL%%_PSEP%" | ||
| set "__TOOLCHAIN=%__TOOLCHAIN%%_JLINE_TERMINAL_JNA%%_PSEP%" | ||
| set "__TOOLCHAIN=%__TOOLCHAIN%%_JNA% |
There was a problem hiding this comment.
No closing quote here
There was a problem hiding this comment.
Good catch ! Adressed review.
liufengyun
approved these changes
Sep 23, 2021
anatoliykmetyuk
approved these changes
Sep 24, 2021
|
@anatoliykmetyuk |
|
@anatoliykmetyuk Thanks ! |
michelou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up of PR #13006.
Related to issue 12502 (WIP : MSI installer created using WiX).
The changes are Windows-specific and have no impact on the CI build.
In particular,
scalac.batshould also work correctly when the Scala 3 installation path contains spaces (e.g.C:\Program Files\Scala 3\).