Skip to content

community build: Cats Effect: use 3.3.x branch, enable JS tests #15628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

community build: Cats Effect: use 3.3.x branch, enable JS tests #15628

wants to merge 1 commit into from

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jul 9, 2022

I don't really remember why I volunteered for this, but I did :-)

@armanbilge told me:

btw, we had a regression in 3.1.3 b/c the JS tests are not being run in the CB I'm not sure if that's just not a thing, or nobody enabled it for some reason

it looks to me like that happened in 1092b35 (ci was replaced with ciJVM), @griggt wdyt? (there is some discussion about the JS tests at #10639 but it isn't clear to me if it's still relevant)

as for series/3.3.x being the right branch, I think it was also Arman who told me:

series/3.3.x is the branch you want for the latest stable release

Sounds plausible that we don't need to track latest series/3.x development until it stabilizes.

@SethTisue
Copy link
Member Author

draft for now until we find out if CI likes it

Verified

This commit was signed with the committer’s verified signature.
asmeurer Aaron Meurer
@griggt
Copy link
Contributor

griggt commented Jul 9, 2022

IIRC the change to just ciJVM was due to a recurrence of the GC thrashing issue and excessively long running times for the test suite (closer to 2 hours than 1). It's a bit of a balancing act to have a useful community build on PR validation that also runs in a reasonable amount of time.

For cats, we have the opposite situtation, build and publishLocal on both JVM and JS but the test suite only runs on JS.

Maybe things have improved again, I haven't checked recently. As you observed, at one point there was no issue with having the test suite run on both platforms.

@SethTisue
Copy link
Member Author

SethTisue commented Jul 10, 2022

There are failures in multiple downstream repos.

Digging into them exceeds my commitment to this, so, closing. Perhaps someone else would like to pick it up?

@SethTisue SethTisue closed this Jul 10, 2022
@SethTisue
Copy link
Member Author

#15773 looks like the new hotness

@armanbilge
Copy link
Contributor

Ah, sorry I missed this PR! Thanks for your efforts :)

@SethTisue SethTisue deleted the community-build-cats-effect branch October 20, 2022 09:12
@SethTisue SethTisue restored the community-build-cats-effect branch October 20, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants