Skip to content

Tweak Http4s in the CB #15773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckipp01 merged 2 commits into from
Jul 28, 2022
Merged

Tweak Http4s in the CB #15773

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
261b2e0
Tweak CE3 and Http4s in the CB
armanbilge Jul 28, 2022
c09e753
Still no JS tests for CE :(
armanbilge Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ object projects:

lazy val catsEffect3 = SbtCommunityProject(
project = "cats-effect-3",
sbtTestCommand = "ciJVM",
sbtTestCommand = "ciJVM; ciJS",
Copy link
Contributor Author

@armanbilge armanbilge Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help prevent JS-specific regressions e.g. #15494.

Copy link
Contributor

@griggt griggt Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how much slowdown this causes.

Copy link
Contributor Author

@armanbilge armanbilge Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, we can't even run these for annoying reasons (namely: an npm dependency). I don't think there's a clean workaround unless the idea in scala-js/scala-js-js-envs#20 (comment) lands which would allow us to drop the npm dep.

Copy link
Contributor Author

@armanbilge armanbilge Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sbtTestCommand = "ciJVM; ciJS",
sbtTestCommand = "ciJVM",

sbtPublishCommand = "publishLocal",
sbtDocCommand = ";coreJVM/doc ;lawsJVM/doc ;kernelJVM/doc",
dependencies = List(cats, coop, disciplineSpecs2, scalacheck)
Expand Down Expand Up @@ -752,7 +752,7 @@ object projects:

lazy val http4s = SbtCommunityProject(
project = "http4s",
sbtTestCommand = """set ThisBuild / tlFatalWarnings := false; server/test; client/test; ember-core/test; ember-server/test; ember-client/test; circe/test""",
sbtTestCommand = """set ThisBuild / tlFatalWarnings := false; rootJVM/test""",
Copy link
Contributor Author

@armanbilge armanbilge Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We slimmed down the http4s repo (it was previously a monorepo). So we should no longer need to pick-and-choose specific modules.

sbtPublishCommand = "publishLocal",
scalacOptions = SbtCommunityProject.scalacOptions.filter(_ != "-Ysafe-init"),
dependencies = List(cats, catsEffect3, fs2, disciplineMunit, scalacheckEffect)
Expand Down