Warn universal extensions on opaque types #22502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Feb 3, 2025
| @@ -1190,7 +1191,7 @@ object RefChecks { | |||
| } | |||
| } | |||
| .exists | |||
| if !target.typeSymbol.isOpaqueAlias && hidden | |||
| if hidden | |||
There was a problem hiding this comment.
That line keeps getting shorter and shorter! 🥲
There was a problem hiding this comment.
I mean, it makes sense to say: if the extension method is hidden, then emit a warning
There was a problem hiding this comment.
It's so simple when you put it like that.
hamzaremmal
reviewed
Feb 3, 2025
hamzaremmal
reviewed
Feb 3, 2025
hamzaremmal
reviewed
Feb 3, 2025
KacperFKorban
approved these changes
Feb 24, 2025
KacperFKorban
pushed a commit
that referenced
this pull request
Mar 10, 2025
Fixes #22705 Fixes #22706 Fixes #22727 Follow-up to #22502 by inserting a `dealias` when arriving at `target` type. Refactored the body of `hidden` to make it easier to read. Adjusted the doc for the same reason. As a reminder to self, the original reason for special handling of aliases was due to subclassing, but overrides are excluded. (One could restore that warning for edge cases.) The long doc explaining the handling of leading implicits is moved to the end (as an appendix). Despite best efforts, I was unable to make the doc longer than the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22232
Work also done by @hamzaremmal, @julian-a-avar-c and @nmcb