Rule Out Exports of Member of the Current Class #22545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odersky I further improved the detection logic in What I'm not sure about: The only difference is that now there is one more cyclicity error occurring in your |
A member that is visible through inheritance or mixin should not be eligible for `export`. We perform the `derivesFrom` check in `canForward` now on the self-type of the exporting class to detect such cycles through mixins. Co-authored-by: Jan-Pieter van den Heuvel <[email protected]> Co-authored-by: Willem W Bakker <[email protected]> Co-authored-by: odersky <[email protected]>
odersky
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22147
Supersedes #22503
Co-authored-by: Jan-Pieter van den Heuvel [email protected]
Co-authored-by: Willem W Bakker [email protected]