Add an -Yimplicit-as-given flag to easily test changes in the ecosystem #22580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It replaces every implicit definition with `given` (including classes, which I was surprised to see working), and every implicit parameter clause with `using`, all in the parser phase. Symbols and trees unpickled from tasty are unaffected by this flag. Trees generated using the reflection api are unaffected as well.
jchyb
force-pushed
the
add-implicit-as-given-flag
branch
from
3a7cc12 to
f7dc85b
Compare
…n as if it was implicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22482
It replaces every implicit definition with
given(including implicit classes, which I was surprised to see working), and every implicit parameter clause withusing, all in the parser phase.Symbols and trees unpickled from tasty are unaffected by this flag. Trees generated using the reflection api are unaffected as well.
Pre
-source:3.6context bounds are left as implicits.All of the above should be easy enough to change, but I didn't really see the purpose for it.