Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nowarn subclasses #22762

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow nowarn subclasses #22762

wants to merge 2 commits into from

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Mar 10, 2025

Implements the "User-defined annotation subclasses" part of #22414, and used it to handle @nowarn subclasses. The "Default expression ASTs" part doesn't have a real world use case for it, so I skipped it for now. And "Runtime uses of annotation classes" part was recently fixed in #22553.

@dwijnand dwijnand marked this pull request as ready for review March 11, 2025 10:03
@dwijnand dwijnand requested a review from lrytz March 11, 2025 10:04
@dwijnand
Copy link
Member Author

dwijnand commented Mar 11, 2025

Need to wait for a release and update of scala-library that includes scala/scala#10976, i.e. scala 2.13.17. Then I can delete the library classes I copied over, and rely on the ones in the stdlib. And I can add another copy of the separate compilation, where the annotation is compiled with scala-compiler 2.13.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant