Backport "Upgrade to Scala.js 1.19.0." to 3.7#23035
Merged
tgodzik merged 3 commits intorelease-3.7.0from Apr 24, 2025
Merged
Conversation
That is the commit that removed calls to `withStrictFloats(true)`, which have been the default since 1.9.0, and cannot be changed since 1.19.0. [Cherry-picked bac43a7]
With minimal changes to preserve the status quo. These are forward ports of compiler, library and build changes from the following upstream commits: * scala-js/scala-js@b38201c Drop support for non-strict floats. * scala-js/scala-js@82910a0 Move well-known names to a new object `WellKnownNames`. * scala-js/scala-js@53dc4fe Introduce `NewLambda` to synthesize instances of SAM types. * scala-js/scala-js@9481522 Rewrite old IR with `AnonFunctionN` references to use `NewLambda`. From the `NewLambda` commit, we only adapt the way we compile Scala function lambdas. We do not use `NewLambda` for arbitrary SAM types yet. This is left for a future, independent commit, as it is not required for correctness.
With minimal changes to preserve the status quo. These are forward ports of compiler, library and build changes from the following upstream commits: * scala-js/scala-js@b38201c Drop support for non-strict floats. * scala-js/scala-js@82910a0 Move well-known names to a new object `WellKnownNames`. * scala-js/scala-js@53dc4fe Introduce `NewLambda` to synthesize instances of SAM types. * scala-js/scala-js@9481522 Rewrite old IR with `AnonFunctionN` references to use `NewLambda`. From the `NewLambda` commit, we only adapt the way we compile Scala function lambdas. We do not use `NewLambda` for arbitrary SAM types yet. This is left for a future, independent commit, as it is not required for correctness. [Cherry-picked 12ca458][modified]
WojciechMazur
approved these changes
Apr 24, 2025
Contributor
WojciechMazur
left a comment
WojciechMazur
left a comment
There was a problem hiding this comment.
LGTM!
If we need a next RC anyway we can also consider adding JDK 25 support from #23004 Although this one can also be postponed to 3.7.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #23026 to the 3.7.0-RC3.
PR submitted by the release tooling.