Actively remove Scala 2 pickles and emit synthetic TASTy attribute for copied stdlib .class files #24846
+281
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
changed the title
WojciechMazur
added
the
backport:nominated
hamzaremmal
reviewed
Dec 30, 2025
| def validRange: String = { | ||
| val min = TastyVersion(major, 0, 0) | ||
| val max = if (experimental == 0) this else TastyVersion(major, minor - 1, 0) | ||
| val extra = Option.when(experimental > 0)(this) |
Contributor
Author
There was a problem hiding this comment.
Because it's compiled using Scala 2.12. For the sake of correctness we're adding tasty sources to unamanged sources of sbt build. See project/build.sbt changes
hamzaremmal
reviewed
Dec 30, 2025
| var stamps = analysis.stamps | ||
|
|
||
| val classDir = (Compile / classDirectory).value | ||
| val sourceDir = (LocalProject("scala-library-nonbootstrapped") / sourceDirectory).value |
Member
There was a problem hiding this comment.
Why does the plugin know about scala-library-nonbootstrapped? It shouldn't.
And even if it were to know about it, why doesn't it know about scala-library-bootstrapped too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24161
Based on and superseeds #24180
We're now actively removing Scala 2 pickle annotations and emit synthetic TASTY attributes (for primary classes). Both of validations are now checked at build time