Also substitute symbols in case bindings symbols #24849
Open
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for scala#24813 is the also updating the symbol in the line ``` to.foreach(sym => sym.info = sym.info.substSym(from, to)) ``` the other changes are more clean up so we only have to do that substitution once. Before scala#7902 the substitution are done both inside substBindings and afterwards. But if done after it the partial substitutions inside are redundant. So this changes it so we only call `subst` one place. It unclear if we expect `subst` to already do this replace? If we do then we should probably fix this in that implementation instead.
eejbyfeldt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24813
The fix for #24813 is the also updating the symbol in the line
the other changes are more clean up so we only have to do that substitution once. Before #7902 the substitution are done both inside substBindings and afterwards. But if done after it the partial substitutions inside are redundant. So this changes it so we only call
substone place.It unclear if we expect
substto already do this replace? If we do then we should probably fix this in that implementation instead.