[build] Use up-to-date sources of Scala 2.13 stdlib when patching Scala 3 bytecode #24855
+12
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Dec 30, 2025
| Build.mimaPreviousDottyVersion -> Seq.empty, // We should never break backwards compatibility | ||
| Build.mimaPreviousDottyVersion -> Seq( | ||
| // scala/scala3#24855 - copied from Scala 2.13.16 by ScalaLibraryPlugin, to be removed when Scala 3.8.0 is released | ||
| ProblemFilters.exclude[MissingClassProblem]("scala.collection.immutable.LazyList$State*"), |
Contributor
There was a problem hiding this comment.
Is this safe? Are we not breaking the binary compatibility here?
Contributor
Author
There was a problem hiding this comment.
It's the same in Scala 2, it was also adds in their MiMa scala/scala#10937 it was removed when they've started to work on 2.13.18 scala/scala@2f929e8 (Scala 2 checks MiMa only against previous version)
We're de facto synchronized with Scala 2.13.18, LazyList.State is a private sealed trait
WojciechMazur
added
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build.stdlibBootstrappedVersion