Skip to content

Collection mutable (2): filled in @param, @tparam, and @return tags that were missed last time#26120

Draft
bvenners wants to merge 1 commit into
scala:mainfrom
artimahub:scaladoc-tags-collection-mutable-cleanup
Draft

Collection mutable (2): filled in @param, @tparam, and @return tags that were missed last time#26120
bvenners wants to merge 1 commit into
scala:mainfrom
artimahub:scaladoc-tags-collection-mutable-cleanup

Conversation

@bvenners
Copy link
Copy Markdown
Contributor

As a next step in improving the Scaladoc documentation for the Scala 3 standard library, this PR fills in @param, @tparam, and @return tags for scala.collection.mutable that were missed in the previous batch of PRs. I'm submitting it as a draft PR so to get CI to run on it, to see if it breaks anything, and to start getting feedback. We automated the generation of these changes and are starting to review them. We will review them all before making the PR non-draft. Please let me know if you see anything specific that you think could be improved.

Copy link
Copy Markdown
Contributor

@cheeseng cheeseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions added.

* exception if no other default behavior was specified.
*
* @param key the key to look up a default value for
* @return the default value supplied by `defaultEntry` for `key`, or throws if no `defaultEntry` was provided
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better if the type of the error/exception being thrown is specified.

* @param maxItems
*/
/** This is a more general version of copyToArray - this also accepts a srcStart unlike copyToArray
* This copies maxItems elements from this collections srcStart to dest's destStart
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:

... this collection's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants