Jdk (7): filled in @param, @tparam, and @return tags that were missed last time#26126
Draft
bvenners wants to merge 1 commit into
Draft
Jdk (7): filled in @param, @tparam, and @return tags that were missed last time#26126bvenners wants to merge 1 commit into
bvenners wants to merge 1 commit into
Conversation
cheeseng
suggested changes
May 22, 2026
Contributor
cheeseng
left a comment
cheeseng
left a comment
There was a problem hiding this comment.
Added some suggestions.
| * `import scala.jdk.FunctionConverters._` and use the extension methods instead. | ||
| * | ||
| * @tparam T the type of the first (object) argument to the consumer | ||
| * @tparam T the type of the first (object) argument to the consumer (the second argument is a primitive) |
Contributor
There was a problem hiding this comment.
Can we says Double instead of primitive here?
| * `import scala.jdk.FunctionConverters._` and use the extension methods instead. | ||
| * | ||
| * @tparam T the type of the first (object) argument to the consumer | ||
| * @tparam T the type of the first (object) argument to the consumer (the second argument is a primitive) |
Contributor
There was a problem hiding this comment.
Can we says Double instead of primitive here?
| * `import scala.jdk.FunctionConverters._` and use the extension methods instead. | ||
| * | ||
| * @tparam T the type of the first (object) argument to the consumer | ||
| * @tparam T the type of the first (object) argument to the consumer (the second argument is a primitive) |
Contributor
There was a problem hiding this comment.
Can we says Int instead of primitive here?
| * `import scala.jdk.FunctionConverters._` and use the extension methods instead. | ||
| * | ||
| * @tparam T the type of the first (object) argument to the consumer | ||
| * @tparam T the type of the first (object) argument to the consumer (the second argument is a primitive) |
Contributor
There was a problem hiding this comment.
Can we says Int instead of primitive here?
| * `import scala.jdk.FunctionConverters._` and use the extension methods instead. | ||
| * | ||
| * @tparam T the type of the first (object) argument to the consumer | ||
| * @tparam T the type of the first (object) argument to the consumer (the second argument is a primitive) |
Contributor
There was a problem hiding this comment.
Can we says Int instead of primitive here?
| * `import scala.jdk.FunctionConverters._` and use the extension methods instead. | ||
| * | ||
| * @tparam T the type of the first (object) argument to the consumer | ||
| * @tparam T the type of the first (object) argument to the consumer (the second argument is a primitive) |
Contributor
There was a problem hiding this comment.
Can we says Int instead of primitive here?
| * [[DoubleAccumulator]]. | ||
| * | ||
| * @tparam CC the covariant higher-kinded type constructor for the specific accumulator collection, constrained to `mutable.Seq` | ||
| * |
Contributor
There was a problem hiding this comment.
I think we do not need the extra line here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a next step in improving the Scaladoc documentation for the Scala 3 standard library, this PR fills in
@param,@tparam, and@returntags forscala.jdkthat were missed in the previous batch of PRs. I'm submitting it as a draft PR so to get CI to run on it, to see if it breaks anything, and to start getting feedback. We automated the generation of these changes and are starting to review them. We will review them all before making the PR non-draft. Please let me know if you see anything specific that you think could be improved.