Relax typer position assert in interactive mode#26130
Open
SolalPirelli wants to merge 3 commits into
Open
Conversation
Member
|
is there a repl completion test suite? |
Contributor
Author
|
Yes, there is, thanks for calling me out on my laziness :) |
SolalPirelli
commented
May 21, 2026
| case (name, CompletionDenotation(denots, site)) if matches0(name) => | ||
| def isAccessible(denot: SingleDenotation): Boolean = | ||
| site.map(denot.symbol.isAccessibleFrom(_)).getOrElse(true) | ||
| site.forall(denot.symbol.isAccessibleFrom(_)) |
Contributor
Author
There was a problem hiding this comment.
first 2 files are minor cleanups I noticed along the way (well, IntelliJ noticed)
SolalPirelli
commented
May 21, 2026
| */ | ||
| def withMonitoringCtrlC[T](handler: () => Unit)(block: => T): T = { | ||
| // If you change Ctrl+C handling in any way, make sure you manually check that | ||
| // If you change Ctrl-C handling in any way, make sure you manually check that |
Contributor
Author
There was a problem hiding this comment.
every other instance in the file uses a hyphen
SolalPirelli
force-pushed
the
solal/repl-completions
branch
from
6c2cd08 to
dbe969c
Compare
SolalPirelli
commented
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25890
This is fixing a symptom, but we already liberally check for interactive mode in the codebase to accept dubious trees. And it fixes a regression; perhaps we can have an issue to remove as many of those interactive checks as possible at some point...
I also added a clearer indication that something went wrong when completions throw an exception.
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
New automated testing
Also manually tested:
buildQuickthen runbin/replQwith the issue's reproducer and see that it works