V2: drop use of unchecked in boundary.apply#26149
Open
bishabosha wants to merge 2 commits into
Open
Conversation
bishabosha
added
the
needs-minor-release
test in compiler/test/dotty/tools/backend/jvm/LabelBytecodeTests.scala that the dropBreaks optimisation still holds. introduce new method `ex.getAsLabelOrThrow[T](local)` on Break class that hides away the cast-or-rethrow logic so safe-mode checking will not see it when it inspects inlined code. Therefore requires minor release. fixes scala#25387
bishabosha
force-pushed
the
stdlib-boundary-internal-cast-throw
branch
from
37bafcc to
498406b
Compare
Member
Author
|
@odersky as you highlighted in the main issue, this would be unnecessary if unsafe checking stops at the boundary of a |
Contributor
|
Yes, I think we should change the compiler's behavior instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce new method
ex.getAsLabelOrThrow[T](local)on Break class that hides away the cast-or-rethrow logic so safe-mode checking will not see it when it inspects inlined code.Therefore requires minor release.
Add case in dropBreaks miniphase to detect and elide the new shape for boundary.apply - tested in compiler/test/dotty/tools/backend/jvm/LabelBytecodeTests.scala
fixes #25387
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
New automated tests