Remove deprecated settings lifted to other categories#26170
Remove deprecated settings lifted to other categories#26170SolalPirelli wants to merge 1 commit into
Conversation
SolalPirelli
added
the
needs-minor-release
| val maybes = Plugin.loadAllFrom(paths, dirs, ctx.settings.disable.value) | ||
| val (goods, errors) = maybes partition (_.isSuccess) | ||
| // Explicit parameterization of recover to avoid -Xlint warning about inferred Any | ||
| // Explicit parameterization of recover to avoid -Wshadow warning about inferred Any |
There was a problem hiding this comment.
Would that be -Winfer-union? I think that comment is from Scala 2. Probably warnings are not turned on anyway?
| @@ -1,4 +1,4 @@ | |||
| //> using options -Werror -Xlint | |||
| //> using options -Werror -Wshadow | |||
There was a problem hiding this comment.
The inpervolator was my favorite interpolator, but unfortunately it is Scala 2-only.
| @@ -1 +1 @@ | |||
| -Xlint -Xfatal-warnings | |||
| -Wshadow -Xfatal-warnings | |||
There was a problem hiding this comment.
I didn't look at whether or how flags files are used in this context.
|
|
||
| object Test { | ||
| "" match { case X(b) => b } // should warn under -Xlint. Not an error because of SI-6111 | ||
| "" match { case X(b) => b } // should warn under -Wshadow. Not an error because of SI-6111 |
There was a problem hiding this comment.
all the untried edits are dubious. Does it matter? It makes the repository larger.
There was a problem hiding this comment.
We definitely shouldn't have comments referencing compiler switches that don't exist. But I'm open to better edits.
There was a problem hiding this comment.
I can't tell which way is more confusing, but I trust your judgment.
2 participants
All the ones that don't need code changes; there are too many for one PR per setting to be useful.
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
Covered by existing tests (this is a refactoring)