-
Notifications
You must be signed in to change notification settings - Fork 27
Limit bbox of volume tracings to that of fallback layer #7580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The backend part of this works now, frontend logging shows that the bbox in the volumetracing proto object is set to the fallback layer bbox. However, I noticed a few strange effects in the frontend
@philippotto can you estimate if these points would be easy to fix in the frontend? If not, maybe I’d defer the issue again (I just thought it would be a quick change in the backend). But this particular behavior is pretty weird and unexpected. |
Regarding the differing visibility of the volume bbox, I'd have to investigate why this is the case.
This is also known (see #5775). Each layer's bbox needs to be passed into the shader and then be handled accordingly. Both issues together might take approx. 2 hours ™️. |
Thanks for investigating! I think it would be worth tackling these two to three issues, but it certainly does not have the highest priority. I guess I’ll let this PR lie here until someone of the frontend team has some free capacity :) |
📝 Walkthrough""" WalkthroughThe changes update the logic for assigning bounding boxes to annotation layers during creation or upload. Now, if a fallback segmentation layer exists, its bounding box is used for the annotation layer instead of the dataset’s bounding box. This adjustment is reflected in both the controller and service layers, with no public API changes. Changes
Assessment against linked issues
Suggested reviewers
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as well and seems to work (at least it did during my testing)
When creating or uploading a non-task volume annotation layer with a fallback segmentation layer, the annotation layer’s bounding box will now be limited to that layer’s, instead of the whole dataset’s.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
fixes Create annotation layer with fallback layer: keep layer bbox #7365
Related PRs Clean up green task bounding boxes #8535, In Data Loading, Clip to Layer BoundingBox #8551, Don't label outside of layer's bbox #8602
Related issues Layer should be clipped at bounding box #5775, Don't label data outside of dataset bbox #6303, Make whole dataset visible when working on tasks #8067