Skip to content

WIP Allow more dataset CRUD via API#9375

Draft
fm3 wants to merge 6 commits intomasterfrom
remote-dataset-more-crud
Draft

WIP Allow more dataset CRUD via API#9375
fm3 wants to merge 6 commits intomasterfrom
remote-dataset-more-crud

Conversation

@fm3
Copy link
Member

@fm3 fm3 commented Mar 9, 2026

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • abc

TODOs:

  • RemoteAttachments.delete_attachment
    • Backend needs to respect missing attachments in updatePartial call
      • ensure frontend or older libs versions don’t already skip the attachments?
      • ensure libs don’t drop attachments on updates when opened via zarr streaming? →LIBS
      • bump API version to v13, ignore attachment changes on older (otherwise we lose attachments unwanted)
  • RemoteAttachments.rename_attachment
  • RemoteDataset.add_layer_as_ref (linked layer)
    • Needs new protocol similar to compose (ensure permission checks)
  • RemoteLayer.add_mag_as_ref (linked mag)
    • Same as above
  • RemoteAttachments.add_attachments_as_ref
    • Same as above
  • RemoteLayer.add_mag_as_copy with transfer_mode=HTTP
    • Needs new upload protocol. Use resumable here too?
  • RemoteAttachments.add_attachment_as_copy with transfer_mode=HTTP
    • Needs new upload protocol (analog to mag)
  • Determine which updates are allowed for non-virtual datasets, make sure those work, make sure others are rejected

Issues:

  • fixes #

(Please delete unneeded items, merge only when none are left open)

  • Added changelog entry (create a $PR_NUMBER.md file in unreleased_changes or use ./tools/create-changelog-entry.py)
  • Added migration guide entry if applicable (edit the same file as for the changelog)
  • Updated documentation if applicable
  • Adapted wk-libs python client if relevant API parts change
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Mar 9, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 202ca4fa-9158-42ef-83b4-73da4627b139

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remote-dataset-more-crud

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant