[Diff PR] Sharding storage transformer for v3 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jstriebel
changed the title
…-storage-transformer
…-storage-transformer
…-storage-transformer
…-storage-transformer
…-storage-transformer
…-storage-transformer
…-storage-transformer
…-storage-transformer
…-storage-transformer
…t-set' into sharding-storage-transformer
…1096) * add storage_transformers and get/set_partial_values * formatting * add docs and release notes * add test_core testcase * Update zarr/creation.py Co-authored-by: Gregory Lee <[email protected]> * apply PR feedback * add comment that storage_transformers=None is the same as storage_transformers=[] * use empty tuple as default for storage_transformers * make mypy happy * better coverage, minor fix, adding rmdir * add missing rmdir to test * increase coverage * improve test coverage * fix TestArrayWithStorageTransformersV3 * Update zarr/creation.py Co-authored-by: Gregory Lee <[email protected]> * pick generic storage transformer changes from zarr-developers#1111 * increase coverage * fix order of storage transformers * retrigger CI * minor fixes * make flake8 happy * apply PR feedback Co-authored-by: Gregory Lee <[email protected]> Co-authored-by: Josh Moore <[email protected]>
…t-set' into sharding-storage-transformer
|
Not needed anymore, since zarr-developers#1096 is merged. Please refer to zarr-developers#1111 directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Notes
This PR provides a readable diff between zarr-developers#1111 and zarr-developers#1096 and is mainly meant for reviews.
Description
This PR
(a more efficient implementation might be a good follow-up)
(some refactoring might be needed in
core.pyto simplify the code-paths, but I'd rather defer this to a separate PR to keep the diff readable)