improvement: Ask to start http server if not running #7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will show up after indexing and users can start the server themselves or ignore it for the session. Should help with scalameta#7072
|
I am still wondering if this will be more useful or whether it might be annoying to people 🤔 |
tgodzik
force-pushed
the
fix-doctor-http-start
branch
from
55b4214 to
3794b0b
Compare
|
I think it's harmless enough improvement, so we can merge that. What do you think @kasiaMarek ? |
kasiaMarek
reviewed
Jan 29, 2025
| def getHttpServer(): Future[Option[MetalsHttpServer]] = { | ||
| httpServer match { | ||
| // If there is no doctor format set then no doctor will be available otherwise | ||
| case HttpServerOff if clientConfig.doctorFormat() == None => |
There was a problem hiding this comment.
What about:
case HttpServerOff if clientConfig.doctorFormat() != None =>Also how can clientConfig.doctorFormat() == None? It has a getOrElse part. Shouldn't it be something in line of clientConfig.isHttpEnabled() == false?
There was a problem hiding this comment.
Ach right. I changed it to use isExecuteClientCommandProvider, since if both that is disabled and no server is running then user might want to start it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show up after indexing and users can start the server themselves or ignore it for the session.
Fixes #7072