bugfix: Add missing type to array in MCP schema #7905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copilot Agent Mode rejects the Metals MCP tool
generate-scalafix-ruledue to an invalid JSON Schema:The tool’s
inputSchema.properties.targetsis"type": "array"but lacks an"items"schema, causing Copilot’s validation to fail and agent mode to break.Steps to Reproduce
sbt new scala/scala3.g8code .Evidence
{ "name": "generate-scalafix-rule", "description": "Generate a scalafix rule and run it on the current project.", "inputSchema": { "type": "object", "properties": { "ruleImplementation": { "type": "string", "description": "The implementation of the scalafix rule to run, this should contain the actual scalafix rule implementation." }, "description": { "type": "string", "description": "The description of the scalafix rule to run for later MCP invocations." }, "targets": { "type": "array", "description": "The targets to run the rule on, if empty will run on the last focused target" // Missing "items": { ... } }, "sampleCode": { "type": "string", "description": "Sample code that we are trying to match in the rule, if nothing was matched an error will be returned with the structure of this sample." }, "fileToRunOn": { "type": "string", "description": "File to run it all, if empty will run on all files in given targets" } }, "required": ["description", "ruleImplementation"] } }