Completions for workspace implicit classes #7919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Oct 23, 2025
| ): Int = { | ||
| if (toplevels.isEmpty && type_hierarchy.isEmpty && toplevelMembers.isEmpty) | ||
| if ( | ||
| toplevels.isEmpty && type_hierarchy.isEmpty && toplevelMembers.isEmpty && implicitClassMembers.isEmpty |
There was a problem hiding this comment.
Couldn't we reuse ToplevelMember for now? And jsut add different kind there?
tgodzik
reviewed
Oct 23, 2025
| public class ImplicitClassMemberResult { | ||
| public final String methodSymbol; | ||
| public final String methodName; | ||
| public final String classSymbol; |
There was a problem hiding this comment.
Don't we just need the class here?
| } | ||
| } | ||
|
|
||
| override def onChange(docs: TextDocuments, path: AbsolutePath): Unit = { |
There was a problem hiding this comment.
We are not using semanticdb, why is this needed?
| s"[MetalsSymbolSearch] Querying implicit class members for type: $paramTypeSymbol" | ||
| ) | ||
|
|
||
| val totalCached = wsp.implicitClassMembers.values.flatten.size |
There was a problem hiding this comment.
I would do all that in the compiler itself, it's much easier to do there. I would just index any implicit classes and then check in the presentation compiler if they apply to the current member.
| * @param range The range of the implicit class in the source file | ||
| */ | ||
| case class ImplicitClassMember( | ||
| classSymbol: String, |
There was a problem hiding this comment.
I would just cache classSymbol, we can't really get the anything else from indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.